Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Sealed 2 traits to forbid downstream implementations #621

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

jorgecarleitao
Copy link
Owner

Also removed the unsafe from them, since they are now sealed (since it was just a way to avoid others from implementing).

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #621 (6001c9d) into main (b3ed162) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
+ Coverage   69.70%   69.72%   +0.01%     
==========================================
  Files         299      299              
  Lines       16599    16599              
==========================================
+ Hits        11571    11573       +2     
+ Misses       5028     5026       -2     
Impacted Files Coverage Δ
src/array/specification.rs 73.17% <ø> (ø)
src/io/parquet/write/levels.rs 94.68% <ø> (ø)
src/types/mod.rs 23.61% <ø> (ø)
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️
src/compute/arithmetics/time.rs 46.93% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ed162...6001c9d. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Sealed 2 traits to forbid downstream implementations. Sealed 2 traits to forbid downstream implementations Nov 21, 2021
@jorgecarleitao jorgecarleitao merged commit 61c2f3c into main Nov 21, 2021
@jorgecarleitao jorgecarleitao deleted the sealed_traits branch November 21, 2021 21:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant