This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Fixed error in computing projection in io::ipc::read::reader::FileReader
#596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dandandan
reviewed
Nov 10, 2021
| @@ -236,7 +236,7 @@ impl<R: Read + Seek> FileReader<R> { | |||
| /// Panics iff the projection is not in increasing order (e.g. `[1, 0]` nor `[0, 1, 1]` are valid) | |||
| pub fn new(reader: R, metadata: FileMetadata, projection: Option<Vec<usize>>) -> Self { | |||
| if let Some(projection) = projection.as_ref() { | |||
| let _ = projection.windows(2).for_each(|x| { | |||
| projection.windows(2).for_each(|x| { | |||
There was a problem hiding this comment.
Looks wonderful! Maybe we can add a test for this to make sure it doesn't panic now?
There was a problem hiding this comment.
Pointer for the tests: /~https://github.com/jorgecarleitao/arrow2/blob/main/tests/it/io/ipc/read/file.rs#L181 (changing from 1 to 0 should be enough :) )
Codecov Report
@@ Coverage Diff @@
## main #596 +/- ##
==========================================
- Coverage 79.16% 79.15% -0.01%
==========================================
Files 400 400
Lines 24892 24890 -2
==========================================
- Hits 19705 19701 -4
- Misses 5187 5189 +2
Continue to review full report at Codecov.
|
Dandandan
approved these changes
Nov 10, 2021
jorgecarleitao
changed the title
io::ipc::read::reader::FileReader
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow projection to be set to 0 in io::ipc::read::reader::FileReader::new by using
windows(2).modified it according to this comment
close #594