-
Notifications
You must be signed in to change notification settings - Fork 224
Validity taken into account when writing StructArray
to json
#511
Validity taken into account when writing StructArray
to json
#511
Conversation
Codecov Report
@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 80.17% 80.20% +0.02%
==========================================
Files 381 381
Lines 23659 23722 +63
==========================================
+ Hits 18969 19026 +57
- Misses 4690 4696 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgecarleitao Should nullable
from Field
influence StructArray
's validity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting approach. I would imagine that we do not need to combine the validities for this, and instead just write a null
to the whole field, but maybe you already went through that exercise and deemed not feasible?
If yes, could you clarify this on the code with a comment? If not, I think it is worth the shot, since it would make the file smaller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome, and very clean with the zip_validity
💯
Left two nits that clippy would complain.
StructArray
to jsonStructArray
to json
Close #500