This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 224
Added support for DataType::Map
and MapArray
#464
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jorgecarleitao
commented
Sep 29, 2021
•
edited
Loading
edited
- physical and logical type
- FFI consume and produce
- IPC consume and produce
- integration tests unskipped
Codecov Report
@@ Coverage Diff @@
## main #464 +/- ##
==========================================
- Coverage 80.19% 79.95% -0.24%
==========================================
Files 374 379 +5
Lines 23025 23215 +190
==========================================
+ Hits 18465 18562 +97
- Misses 4560 4653 +93
Continue to review full report at Codecov.
|
jorgecarleitao
changed the title
Added support for
Added support for Sep 29, 2021
Map
and MapArray
DataType::Map
and MapArray
jorgecarleitao
force-pushed
the
map
branch
4 times, most recently
from
September 30, 2021 15:13
dc5aa1c
to
5c8f646
Compare
nevi-me
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments on some error messages
jorgecarleitao
commented
Oct 2, 2021
Co-authored-by: Wakahisa <nevilledips@gmail.com>
Thank you very much, @nevi-me for your review (great to see you :D) |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.