Revamp #27
Merged
Revamp #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🥳 |
better late than never haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes many long date issues with the SlideOverCard package, including:
✨ Now, the
.slideOverCard(:_)modifier uses theSOCManagerby default for presentation, meaning it can now present a card over the entire view hierarchy from any child view. To keep this package streamlined, theSOCManagerclass and theSlideOverCardview have been made private as they're no longer needed. Deprecated structs and initializers have also been removed.🛠️ The presentation behavior in the
SOCManagerhas also been improved substantially — now you can present cards over sheets, tab views and much more. Also, all animation issues were fixed.👆Now, cards can be dismissed by an outside tap. To disable this behavior, just include
.disableTapToDismissin yourSOCOptions.📱 The default corner radius of the cards is now automatically calculated by the device's bezels' corner radius and the
outerPaddingparameter.📁 The project's file structure has been revamped, and the README has been adjusted and streamlined.
🎆 There's also a new, shinier icon!
This pull request resolves #6, resolves #10, resolves #13, resolves #17, resolves #18, resolves #19 and resolves #23.