Upgrade autolinker #356
Merged
Upgrade autolinker #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs #340 /~https://github.com/gregjacobs/Autolinker.js/releases - fixed test - dropped twitter option - dropped rollup commonjs plugin as autolinker is distributed as esm now
3 similar comments
|
Friendly ping @jonschlinkert @doowb @shockey |
|
@TrySound Are you sure you fixed and didn't break the test? See gregjacobs/Autolinker.js#278 |
|
Damn, missed your comment in that PR |
|
I see in this test that such behaviour is expected. |
|
I extended version range so users could upgrade autolinker when the new version is out. If the behaviour will not fit to users they may copy paste lunkify plugin into own code base and use any lib and version without any loss. Linkify plugin is a separate entry point now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #340 and /~https://github.com/gregjacobs/Autolinker.js/releases
/cc @kibertoad