Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't enforce single page pagination since 3.0 update #1147

Closed
solomspd opened this issue Nov 20, 2023 · 4 comments
Closed

can't enforce single page pagination since 3.0 update #1147

solomspd opened this issue Nov 20, 2023 · 4 comments
Labels
question Further information is requested

Comments

@solomspd
Copy link

Question:
Since 3.0, I can't enforce single page pagination, there does not seem to be that kind of setting exposed in the menu nor does there seem to be any way of passing that setting.

I wanted to ask if this is intended behavior and if so this setting would be something I'd like to contribute.

Note, when setting the maximum number of columns to 1, it still always shows two pages sides by side when reading .cbz. files that are mostly images (manga). For that matter, changing the number of columns does not affect the number of pages displayed

Version:

  • Foliate version: 3.0.1
  • OS/Distribution and version: Arch Linux
  • Desktop environment: Hyprland
  • Installation method: pacman
@solomspd solomspd added the question Further information is requested label Nov 20, 2023
@johnfactotum
Copy link
Owner

johnfactotum commented Nov 20, 2023

Currently it isn't possible unless you convert it to EPUB and set the rendition:spread property. If the property isn't set or is auto, it's treated as landscape, and it will render synthetic spreads if the viewport width is greater than the height.

To fix this there would probably need to be per-book settings. And the natural way to do that would be to save dir (#745) and rendition in the book data (these keys are the ones currently used in foliate-js; however it might be better to save them as readingProgression and presentation to match webpub).

Alternatively/additionally, it could save a set of default rendition settings globally. But maybe it would be okay to make it always default to default/auto.

@solomspd
Copy link
Author

thank you! I'm going through the source code. Am I reading it correctly that I should start looking starting ./src/foliate-js/comic-book.js. Are there any other relevant files?

@johnfactotum
Copy link
Owner

No, comic-book.js is only relevant if you want to add support for CBZs that contain metadata on whether synthetic spreads should be used.

If one wishes to make it configurable then it needs to be implemented in src/book-viewer.js and src/reader/reader.js.

@johnfactotum
Copy link
Owner

Closing this in favor of #1396

@johnfactotum johnfactotum closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants