Upgrade to bevy 0.15 #466
Merged
Upgrade to bevy 0.15 #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I think the wasm build broke because web-sys got upgraded in cargo toml, and it doesn't seem to follow semver... perhaps we should pin the patch version? Won't let it block this PR, though. PR looks great, thanks a lot! Will merge as soon as bevy_ggrs is out and this depends on the crates release. |
|
I cherry-picked the web-sys commit to #473 and updated all other dependencies except bevy and bevy_ggrs. Feel free to either rebase or merge main into this one. |
|
bevy_ggrs 0.17 is out now, so this is unblocked :) |
|
Did some rebasing and got it to build, will rely on the pipe to catch problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is blocked by bevy_ggrs, but I thought I might get the ball rolling somewhat to speed up the overall process. I put temporary deps to my fork of bevy_ggrs, which I used for the upgrade PR.
Like I said in my bevy_ggrs PR, I'm not a 100% certain I got it right. Everything compiles, tests pass, clippy is happy and I got the hello example to work just fine, which gives me a lot of hope, but I'm still not confident. Please review carefully.
Hope this helps with the upgrade.