Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows gks_qt fix #477

Merged
merged 1 commit into from
Oct 6, 2022
Merged

windows gks_qt fix #477

merged 1 commit into from
Oct 6, 2022

Conversation

t-bltg
Copy link
Contributor

@t-bltg t-bltg commented Oct 6, 2022

Fix #475.

@BioTurboNick, if you could confirm, thanks a lot.

I really don't know how to write a test for this, so it does not reproduce ...
We really need low-level gr debugging tools (JuliaPlots/Plots.jl#4375 (comment)).

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 40.46% // Head: 40.52% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (e420852) compared to base (85b578a).
Patch coverage: 57.14% of modified lines in pull request are covered.

❗ Current head e420852 differs from pull request most recent head 8cb2e49. Consider uploading reports for the commit 8cb2e49 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   40.46%   40.52%   +0.05%     
==========================================
  Files           7        7              
  Lines        2696     2697       +1     
==========================================
+ Hits         1091     1093       +2     
+ Misses       1605     1604       -1     
Impacted Files Coverage Δ
src/GR.jl 30.59% <57.14%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@t-bltg
Copy link
Contributor Author

t-bltg commented Oct 6, 2022

@jheinen, once confirmed can you merge and release 0.69.4 (or maybe give me write rights to this repo) ? Sorry for disturbing your holidays.

Even better, GR.jl could be transferred to the JuliaPlots organization for easier maintenance (since it is the primary Plots backend).

@BioTurboNick
Copy link

Confirmed, works on Windows.

@jheinen
Copy link
Owner

jheinen commented Oct 6, 2022

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GKS problem on Win11
4 participants