Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code ChatSet #480

Merged
merged 1 commit into from
Oct 20, 2018
Merged

Remove dead code ChatSet #480

merged 1 commit into from
Oct 20, 2018

Conversation

regisd
Copy link
Member

@regisd regisd commented Oct 19, 2018

According to the dependency graph, CharSet and CharSetEnumerator are unused.

Are they part of the public or dead code?

@regisd regisd requested a review from lsf37 as a code owner October 19, 2018 20:57
@regisd regisd added this to the 1.7.1 milestone Oct 19, 2018
@regisd regisd self-assigned this Oct 19, 2018
@regisd regisd added the code quality Code health and clean-up label Oct 19, 2018
lsf37
lsf37 approved these changes Oct 19, 2018
View reviewed changes
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like they are indeed dead code. Ok to remove from my side.

@regisd regisd merged commit fcc4ea9 into jflex-de:master Oct 20, 2018
regisd pushed a commit that referenced this pull request Oct 20, 2018
@traviscibot
Pseudo-Merge commit fcc4ea9
e61c6fe 
Author: Régis Décamps <regisd@google.com>
Date:   Sat Oct 20 09:20:07 2018 +0200

    Remove dead code ChatSet (#480)

Updated from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
regisd pushed a commit that referenced this pull request Oct 20, 2018
@traviscibot @regisd
Pseudo-Merge commit fcc4ea9
7175561 
Author: Régis Décamps <regisd@google.com>
Date:   Sat Oct 20 09:20:07 2018 +0200

    Remove dead code ChatSet (#480)

Updated from target/jflex-parent-1.7.1-SNAPSHOT-sources.jar
@regisd regisd deleted the rm-dead-code branch October 28, 2018 20:45
@lsf37 lsf37 modified the milestones: 1.7.1, 1.8.0 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsf37 lsf37 lsf37 approved these changes

Assignees

@regisd regisd

Labels
code quality Code health and clean-up
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@regisd @lsf37