This repository has been archived by the owner on Nov 29, 2024. It is now read-only.
Add JTS geometry/GeoJson support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buehner
force-pushed
the
jts-geojson-support
branch
from
22deb92 to
ba383c0
Compare
|
Thanks for you PR, |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already proposed in #23, it would be nice to have the ability to access the geometries of addresses. Currently, this is not possible as
polygonpointsis deprecated (and always null in the address results!?).When using the
PolygonFormat.GEO_JSONformat, geojson will be inlcuded in the result sets , but it has not yet been deserialized by GSON.To solve this problem, this PR
geojsonfield to theAddressmodel. The type of the new field iscom.vividsolutions.jts.geom.Geometryfrom the popular JTS library.geogson-jtsto register itsJtsAdapterFactoryandGeometryAdapterFactoryto thegsonBuilder, so that the GeoJson can easily be deserialized by Gson (as described here)I also added a test to check the new functionality.
On top of that, some of the dependencies in the POM have been updated.