Prefix descriptor names of custom serializers #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kotlinx.serialization library added a new UUID serializer in 1.7.2 for the (experimental) UUID type in the Kotlin stdlib. Unfortunately this causes an issue, their serializer uses the same (simple-)name as ours, causing an exception when trying to encode/decode JSON.
The fix is two-sides, they'll fix their side to use more strict name validation. And we'll fix it to use a more unique name. On the upside, this will also improve the experience for users of the SDK, as they will also be less likely to have a serializer with a name we also use.