Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require full screen on iOS #430

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Don't require full screen on iOS #430

merged 1 commit into from
Nov 8, 2024

Conversation

Cyberbeni
Copy link
Contributor

@Cyberbeni Cyberbeni commented Apr 26, 2023

fixes #426
fixes #376

couldn't test it because the Expo Go app already supports split screen and couldn't figure out how to build the standalone app

@sonarqubecloud

This comment has been minimized.

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.21%. Comparing base (af44e42) to head (f206aa5).
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   60.21%   60.21%           
=======================================
  Files          46       46           
  Lines         945      945           
  Branches      189      189           
=======================================
  Hits          569      569           
  Misses        341      341           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anthonylavado anthonylavado self-requested a review May 1, 2023 15:47
@thornbill thornbill added the bug Something isn't working label May 24, 2023
@thornbill thornbill added this to the v1.6.0 milestone May 24, 2023
Copy link

@thornbill
Copy link
Member

I need to do some additional testing, but it doesn't seem like this is needed in the updated version of Expo.

@Cyberbeni
Copy link
Contributor Author

If I remember correctly if a new enough Expo version is specified in some config file then it is not needed. But if a newer Expo version is used for building but the config is not updated then it is needed.
Or maybe the config part is not needed, I don't know.
But when downloading "Expo Go" from the App Store then requiresFullScreen is set to false for that application and the config for the in-development application doesn't matter.

@Cyberbeni
Copy link
Contributor Author

According to my comments on this issue, either sdkVersion or requireFullScreen is needed in app.json: #426
The part I linked there is still unchanged in Expo's source code: /~https://github.com/expo/expo/blob/0a999ca61531f3064e589be623ff0d7f8247cebe/packages/%40expo/config-plugins/src/ios/RequiresFullScreen.ts#L23-L25

@thornbill thornbill merged commit 10afb7e into jellyfin:master Nov 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Can't go fullscreen on external monitor Split screen does not work on iPadOS 15
4 participants