-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require full screen on iOS #430
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 60.21% 60.21%
=======================================
Files 46 46
Lines 945 945
Branches 189 189
=======================================
Hits 569 569
Misses 341 341
Partials 35 35 ☔ View full report in Codecov by Sentry. |
|
I need to do some additional testing, but it doesn't seem like this is needed in the updated version of Expo. |
If I remember correctly if a new enough Expo version is specified in some config file then it is not needed. But if a newer Expo version is used for building but the config is not updated then it is needed. |
According to my comments on this issue, either sdkVersion or requireFullScreen is needed in app.json: #426 |
fixes #426
fixes #376
couldn't test it because the Expo Go app already supports split screen and couldn't figure out how to build the standalone app