Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report to server when download stops #408

Merged
merged 5 commits into from
Dec 2, 2022

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Dec 1, 2022

Reports when a download stops (completes or errors out) so the server can remove the transcode files.

@thornbill thornbill added the cleanup Cleanup of legacy code or code smells label Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #408 (81a35da) into master (e6b31c6) will decrease coverage by 0.32%.
The diff coverage is 30.00%.

❗ Current head 81a35da differs from pull request most recent head da1c826. Consider uploading reports for the commit da1c826 to get more accurate results

@@            Coverage Diff             @@
##           master     #408      +/-   ##
==========================================
- Coverage   60.53%   60.21%   -0.33%     
==========================================
  Files          46       46              
  Lines         935      945      +10     
  Branches      187      189       +2     
==========================================
+ Hits          566      569       +3     
- Misses        336      341       +5     
- Partials       33       35       +2     
Impacted Files Coverage Δ
App.js 0.00% <0.00%> (ø)
models/DownloadModel.ts 100.00% <100.00%> (ø)
stores/RootStore.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thornbill thornbill changed the title Transcode cleanup Report to server when download stops Dec 1, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thornbill thornbill marked this pull request as ready for review December 1, 2022 19:22
@thornbill thornbill merged commit 94e33b6 into jellyfin:master Dec 2, 2022
@thornbill thornbill deleted the transcode-cleanup branch December 2, 2022 16:46
@thornbill thornbill added this to the v1.6.0 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells
Development

Successfully merging this pull request may close these issues.

2 participants