Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more component tests #323

Merged
merged 6 commits into from
Nov 20, 2021

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Nov 4, 2021

Adds tests for:

  • SwitchListItem badge
  • ErrorView
  • RefreshWebView
  • Links
  • ThemeSwitcher

The *.snap files are generated snapshots by jest, so they don't require too thorough of a review 😉

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #323 (1436486) into master (884504b) will increase coverage by 11.72%.
The diff coverage is 100.00%.

❗ Current head 1436486 differs from pull request most recent head 17da186. Consider uploading reports for the commit 17da186 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master     #323       +/-   ##
===========================================
+ Coverage   32.81%   44.53%   +11.72%     
===========================================
  Files          37       37               
  Lines         710      714        +4     
  Branches      144      145        +1     
===========================================
+ Hits          233      318       +85     
+ Misses        430      355       -75     
+ Partials       47       41        -6     
Impacted Files Coverage Δ
components/SwitchListItem.js 100.00% <ø> (+14.28%) ⬆️
components/ErrorView.js 100.00% <100.00%> (+100.00%) ⬆️
components/ServerInput.js 100.00% <100.00%> (+100.00%) ⬆️
components/RefreshWebView.js 63.63% <0.00%> (+63.63%) ⬆️
constants/Links.js 100.00% <0.00%> (+100.00%) ⬆️
hooks/useStores.js 100.00% <0.00%> (+100.00%) ⬆️
components/ThemeSwitcher.js 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884504b...17da186. Read the comment docs.

@thornbill thornbill force-pushed the moar-component-tests branch from 8a21b53 to 81cebf2 Compare November 15, 2021 15:13
@thornbill thornbill force-pushed the moar-component-tests branch 2 times, most recently from 9c345d8 to 1436486 Compare November 16, 2021 16:23
@thornbill thornbill marked this pull request as ready for review November 16, 2021 16:35
@thornbill thornbill force-pushed the moar-component-tests branch from 1436486 to 17da186 Compare November 17, 2021 04:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@anthonylavado anthonylavado merged commit 71bf744 into jellyfin:master Nov 20, 2021
@thornbill thornbill deleted the moar-component-tests branch November 21, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants