Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipping to next episode #4072

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

nielsvanvelzen
Copy link
Member

When a media segment skips to the end of the video, the app would misbehave and often just close the player instead of going to the next item. This change adds a fast-path to prevent this from happening.

Changes

  • Prevent CustomPlaybackOverlayFragment from navigating multiple times
  • Add "skipToNext" option to PlaybackController.seek to allow skipping to a next queue item if the position is at the end of the current item (>= duration - 100ms)

Issues

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Oct 13, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.18.0 milestone Oct 13, 2024
@nielsvanvelzen nielsvanvelzen merged commit cade3fd into jellyfin:master Oct 13, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the skip-to-next branch October 30, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants