-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/Remove Dates When Publishing/Unpublishing #92
Conversation
@gavinhoward Good Job with learning the new stuff. |
@ashmaroli thank you. If it helps, I feel no particular need to be credited. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some changes to be made..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But would help to get a second opinion since the recent changes are my suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @gavinhoward 👍
@jekyllbot: merge +minor |
Yes! \o/ |
My second attempt to fix dates when publishing and unpublishing. The first attempt was #91, and it had several problems. I believe that this PR fixes the problems with #91 that I was told about; if not, please let me know.
I took the time to learn how to use
git merge
better, so after some work, I was able to keep @alzeih's commit (and authorship) intact.I hope that it was okay to put myself as the author on the other commits, though.
Anyway, here are the changes I made:
/script/fmt
, though I did fix each one manually (not with/script/fmt -a
).This commit will close #55 and will also resolve #63.
@wip ready for review