Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for collections_dir configuration #74

Merged
merged 3 commits into from
Oct 31, 2018
Merged

Add support for collections_dir configuration #74

merged 3 commits into from
Oct 31, 2018

Conversation

ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Oct 8, 2018 •
edited
Loading

Read the collections_dir config setting to create, publish and unpublish posts and drafts into the correct location.

  • Add Implementation
  • Add Tests

Resolves #62

@ashmaroli ashmaroli force-pushed the collections-dir-support branch from ad6e38d to 2965cf6 Compare October 9, 2018 11:29
@ashmaroli ashmaroli changed the title WIP: Add support for collections_dir configuration Add support for collections_dir configuration Oct 9, 2018
@ashmaroli ashmaroli force-pushed the collections-dir-support branch from f3f033e to f4e8655 Compare October 9, 2018 11:41
DirtyF
DirtyF approved these changes Oct 9, 2018
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DirtyF DirtyF requested a review from a team October 9, 2018 17:02
@DirtyF
Copy link
Member

DirtyF commented Oct 31, 2018

@ashmaroli: woops, I messed up indentation for the last context, I cannot push on your branch, can you fix it? Thanks.

@ashmaroli ashmaroli force-pushed the collections-dir-support branch from e27071f to 5de5b26 Compare October 31, 2018 13:35
@ashmaroli
Copy link
Member Author

@DirtyF I had to reset the branch and pull master again to resolve conflicts..

@ashmaroli ashmaroli force-pushed the collections-dir-support branch from 5de5b26 to a25f53d Compare October 31, 2018 13:59
@DirtyF
Copy link
Member

DirtyF commented Oct 31, 2018

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 942d46e into jekyll:master Oct 31, 2018
jekyllbot added a commit that referenced this pull request Oct 31, 2018
@jekyllbot
Update history to reflect merge of #74 [ci skip]
f063a95
@ashmaroli ashmaroli deleted the collections-dir-support branch October 31, 2018 15:43
@mitchellbusby mitchellbusby mentioned this pull request Jun 9, 2019
Closed
@jekyll jekyll locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
enhancement frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for collections_dir
3 participants
@ashmaroli @DirtyF @jekyllbot