Execute FileInfo tests in source_dir, Fix tests #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to some ArgParser specifics, the FileInfo test broke others when run in the root project dir before others. This can be reproduced with script/cibuild --order rand:22787 command. I've created a before hook for FileInfo test which changes dir to source_dir before running FileInfo tests. This fixes other tests failing when running after FileInfo test
parkr
approved these changes
Nov 14, 2017
|
Thank you! @jekyllbot: merge +dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some ArgParser specifics, the FileInfo test broke others when run
in the root project dir before others. This can be reproduced with
command.
I've created a before hook for FileInfo test which changes dir to
source_dir before running FileInfo tests. This fixes other tests
failing when running after FileInfo test