Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of config.guest_user should not require explicitly initialising the Repository #29

Closed
jdickey opened this issue Feb 27, 2019 · 1 comment
Closed

Use of config.guest_user should not require explicitly initialising the Repository #29

jdickey opened this issue Feb 27, 2019 · 1 comment
Assignees
@jdickey
Labels
bug Something isn't working
Milestone
Version 0.2.3

Comments

@jdickey
Copy link
Owner

jdickey commented Feb 27, 2019

This introduces a change where config.guest_user works correctly even if no value has been assigned to config.repository. It does so by explicitly assigning a new UserRepository instance to config.repository.

Marked as a bug rather than a feature because the previous setup was nonsensical.
@jdickey jdickey added the bug Something isn't working label Feb 27, 2019
@jdickey jdickey self-assigned this Feb 27, 2019
@jdickey jdickey added this to the Version 0.2.3 milestone Feb 27, 2019
jdickey added a commit that referenced this issue Feb 27, 2019
@jdickey
Merge tag 'v0.2.3' into develop
262da16 
Initialise :repository and :guest_user attributes automatically

See Issue [#29](#29).

* tag 'v0.2.3':
  Prepare to release v0.2.3
jdickey added a commit that referenced this issue Feb 27, 2019
@jdickey
Initialise :repository and :guest_user attributes
6201b09 
These are now initialised in the new `self.included` method, eliminating the previous need to explicitly initialise a value for `config.repository` *every single time.

Want to do it differently? Create your own module that includes or extends `CryptIdent`, and follow this example.

[Closes #29]

86 tests, 113 assertions, 0 failures, 0 errors, 0 skips
Coverage: 1012 / 1012 LOC (100.0%) covered.
RuboCop: 11 files inspected, no offenses detected
Flay: Total score 0
Flog: Total 326.1; method average 4.7; max 8.4 (CryptIdent::SignUp#create_result)
Reek: 0 total warnings
Inch: Nothing to suggest
@jdickey
Copy link
Owner Author

jdickey commented Mar 5, 2019

Closed by Commit 242e777; released as part of Gem Version 0.2.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdickey jdickey

Labels
bug Something isn't working
Projects
None yet
Milestone
Version 0.2.3
Development

No branches or pull requests
1 participant
@jdickey