Use __qualname__ for struct tags
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a struct's tag was generated from its `__name__`. We now generate it from its `__qualname__`, excluding any leading namespaces from nested functions. This means that (nested) structs should be tagged the same if defined dynamically within a function as if they were defined at the top level. This is a breaking change, but should only affect users making use of tagged nested structs relying on the default tagging behavior. A user falling into this category seems unlikely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a struct's tag was generated from its
__name__. We now generate it from its__qualname__, excluding any leading namespaces from nested functions. This means that (nested) structs should be tagged the same if defined dynamically within a function as if they were defined at the top level.This is a breaking change, but should only affect users making use of tagged nested structs relying on the default tagging behavior. A user falling into this category seems unlikely.
Fixes #395.