Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.8 support #368

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Drop Python 3.8 support #368

merged 1 commit into from
Jul 11, 2024

Conversation

jbms
Copy link
Owner

@jbms jbms commented Jul 11, 2024

While Python 3.8 is not officially EOL, NumPy dropped Python 3.8 support with NumPy 1.25 released Jun 2023.

https://numpy.org/news/#numpy-1250-released

@jbms jbms requested a review from 2bndy5 July 11, 2024 19:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.91%. Comparing base (1aa0123) to head (b864258).
Report is 31 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   63.98%   63.91%   -0.08%     
==========================================
  Files          67       67              
  Lines        8086     8070      -16     
==========================================
- Hits         5174     5158      -16     
  Misses       2912     2912              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2bndy5
Copy link
Collaborator

2bndy5 commented Jul 11, 2024

should imply a minor version bump

@jbms jbms merged commit 69b7a7d into main Jul 11, 2024
60 checks passed
@jbms jbms deleted the drop-py38 branch July 11, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants