FIX: Don't check wandb assert if not using wandb #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-pollak
pushed a commit
to tom-pollak/SAELens
that referenced
this pull request
Oct 22, 2024
FIX: Don't check wandb assert if not using wandb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
DashboardRunner fails when use_wandb=False
Cause:
DashboardRunner does an assert at the end to check if "run" (a wandb variable) is not None, even if use_wandb is set to False. This will always fail when use_wandb is False because "run" isn't initialized.
Fix:
Add check for use_wandb before doing this assert and other code for uploading to wandb.
Possible modifications / other considerations:
Should we still zip up the folder and/or delete it?