Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix problem with element scope #352

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix: Fix problem with element scope #352

merged 1 commit into from
Apr 11, 2022

Conversation

zhaokun1219
Copy link
Contributor

  1. Fix the problem of element scope. Shortcut keys only take effect on specific elements
  2. The default element option is document, but the test case named "unbind with method test" passes document.body triggers the event, which will bubble on the document. Previously, the callback was called twice (one triggered by document.body and one triggered by document). But now we have fixed the bug in the element scope, so the callback will only be called once
  3. The default timeout of a hook in "jest" is 30s, but the startup time of "puppeter" is too long, which leads to an error when the execution time of "beforeAll" hook exceeds 30 seconds occasionally, so the timeout of "beforeAll" is extended

@zhaokun1219
Copy link
Contributor Author

This solves the issue #247

@jaywcjlove jaywcjlove merged commit 973e607 into jaywcjlove:master Apr 11, 2022
@jaywcjlove
Copy link
Owner

@zhaokun1219 thx!

jaywcjlove added a commit that referenced this pull request Apr 11, 2022
github-actions bot pushed a commit that referenced this pull request Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants