Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect NNN_TRASH in .nmv #1306

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Respect NNN_TRASH in .nmv #1306

merged 1 commit into from
Feb 14, 2022

Conversation

KlzXS
Copy link
Collaborator

@KlzXS KlzXS commented Feb 13, 2022

In response to #1292 (comment)

I'm not familiar with the functioning of the trash programs so I don't know if any flags are needed.
rm has an interactive flag, but since trashing doesn't automatically delete files I take it that isn't even needed.

@N-R-K
Copy link
Collaborator

N-R-K commented Feb 13, 2022

trash-put doesn't need any flags, idk about gio trash. Also should we grep through all the plugins to see if there's any other plugin where it makes sense to respect NNN_TRASH ?

@KlzXS
Copy link
Collaborator Author

KlzXS commented Feb 13, 2022

NNN_TRASH isn't used anywhere else.
dups removes files. But it removes identical files, what's the point in putting it in the trash if you have an identical copy elsewhere? Most other result of grep rm are tmpfile removals.

@jarun jarun merged commit 30bd6a4 into jarun:master Feb 14, 2022
@jarun
Copy link
Owner

jarun commented Feb 14, 2022

Thank you!

@jarun jarun mentioned this pull request Feb 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants