Parent activity interface added + missing functions added #195

MFlisar · 2017-03-21T07:28:58Z

Added a small parent activity callback to forward create view / destroy view events of the slides:

id added to slides to distinguish the slides in the callbacks
added getter for each important view of the slides so that they can be used in the callbacks

Other small changes:

getCurrentSlidePosition added (people may want to scroll to next/previous page or want to handle the back press differently if current position == 0)
goToItem manually to scroll to any position

* added ids to SimpleSlide

removed I prefix from interface

…ng the activity after rotation

…ntro Removed conflicting changes, not necessary anymore anyways

CLAassistant · 2017-03-21T07:29:59Z

All committers have signed the CLA.

…ntro # Conflicts: # library/src/main/res/layout-land/mi_fragment_simple_slide.xml # library/src/main/res/layout/mi_fragment_simple_slide.xml

janheinrichmerker · 2017-03-21T07:37:49Z

library/src/main/java/com/heinrichreimersoftware/materialintro/app/IntroActivity.java

    public Fragment getItem(int position) {
        return adapter.getItem(position);
    }

+    @SuppressWarnings("unused")


See #166 and 8757d41.
It's already implemented.

janheinrichmerker · 2017-03-21T07:40:34Z

library/src/main/java/com/heinrichreimersoftware/materialintro/slide/SimpleSlide.java

@@ -34,7 +35,7 @@
    private static final int DEFAULT_PERMISSIONS_REQUEST_CODE = 34; //Random number
    private SimpleSlideFragment fragment;

-
+    private final int id;


Normally IDs are saved as long on Android. Not sure if that would make a huge difference, but if it's not too much effort for you, please change it.

I thought about resource ids as default (mostly, you'll just use the title resource id for this imho), altough using simple ints like 1, 2, 3, ... would be fine as well, I don't want to force anyone to create ids for this... But changing it to long is no problem

Hmm yes, then just change it to long

janheinrichmerker · 2017-03-21T07:42:17Z

library/src/main/java/com/heinrichreimersoftware/materialintro/slide/SimpleSlideActivity.java

+
+import android.view.View;
+
+/**


Please delete default file template.

done as well

janheinrichmerker · 2017-03-21T07:44:54Z

library/src/main/java/com/heinrichreimersoftware/materialintro/slide/SimpleSlide.java

+        }
+
+        public LinearLayout getInnerLinearLayout() {
+            return innerLinearLayout;


Not really necessary to reveal the internal layout to the public API. This can change soon as I'm adopting ConstraintLayout atm. Just have methods for the TextView's and the ImageView.

I need it, I'll add checkboxes and progress bars to this layout and as I saw, this inner layout container is still present in your updated layouts. Really want to remove it?

If you want to add views and things like that, SimpleSlide is probably not the best way to go. The somplest solution would be a FragmentSlide with your Fragment or layout resource.

SimpleSlide should keep as simple as possible. Just for basic intros like in the material specs

That's fine. I just think, the SimpleSlide already has all the rotation code in it and can be reused. I can remove the getInnerLinearLayout.

Anyways, following works as well for both layouts (landscape and portrait) currently: LinearLayout ll = (LinearLayout)fragment.getTitleView().getParent();

A bit hacky though 😄
Basically SimpleSlide is the out of the box solution for say 80% of all intros and when you need forms or inputs or custom layouts, you could either use FragmentSlide with a Fragment or even create a fully customized Slide

I understand. I just don't want to reimplement the fragment for such a simple function. Maybe extending the SimpleSlide to support a CheckBox and ProgressBar via the builder would be a the better alternative

janheinrichmerker · 2017-03-21T08:00:22Z

library/src/main/java/com/heinrichreimersoftware/materialintro/app/IntroActivity.java

@@ -1275,11 +1275,6 @@ public int getCurrentSlidePosition() {
    }

    @SuppressWarnings("unused")
-    public Fragment getItem(int position) {


I didn't want getItem() to be removed but goToItem() 😆

my fault, sorry...

…de for it fixed the accidently wrong removed getItem and removed the duplicate goToItem instead

janheinrichmerker · 2017-03-21T08:12:23Z

Great!! So everything left is signing the CLA and waiting the Travis build to finish 😃

MFlisar · 2017-03-21T08:13:24Z

I already signed it ;-).

janheinrichmerker · 2017-03-21T08:14:41Z

Well that's weird.. The bot says it's not signed because it doesn't recognize you as GitHub user...

MFlisar · 2017-03-21T08:15:32Z

I see the message here as well, but when clicking details it tells me I have already signed it...

janheinrichmerker · 2017-03-21T08:16:26Z

Have you checked your linked GitHub email: https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user

janheinrichmerker · 2017-03-21T08:18:52Z

Travis finished successful! 👍

MFlisar · 2017-03-21T08:24:06Z

Now I saw it, I somehow have committed with a different email address. Did not know that's possible, my github account does not know it... But found the reason now

janheinrichmerker · 2017-03-21T08:40:15Z

@MFlisar you have to link the email address from your commits (mflisar@gmail.com) to your GitHub account. Then the commits should be recognized by GitHub (you can see that by checking if your GitHub avatar appears in the commit view).

MFlisar · 2017-03-21T08:41:26Z

I know. I would prefer to change the commit email though. But I'll add it for now.

janheinrichmerker · 2017-03-21T08:41:58Z

That would work too

MFlisar added 7 commits March 16, 2017 14:30

added a getCurrentSlidePosition function

976ddf0

* added ISlideActivity

89ce827

* added ids to SimpleSlide

added view getters to SimpleSlideFragment

d43c93d

removed I prefix from interface

simple flag to disable the finish check, can be used to avoid finishi…

d8a9587

…ng the activity after rotation

Merge branch 'master' of /~https://github.com/HeinrichReimer/material-i…

3c782d1

…ntro Removed conflicting changes, not necessary anymore anyways

clean up

843a27f

renamed interface method

4b01ddb

Merge branch 'master' of /~https://github.com/HeinrichReimer/material-i…

bd9a9e2

…ntro # Conflicts: # library/src/main/res/layout-land/mi_fragment_simple_slide.xml # library/src/main/res/layout/mi_fragment_simple_slide.xml

janheinrichmerker requested changes Mar 21, 2017

View reviewed changes

MFlisar added 2 commits March 21, 2017 08:52

changes due to comments done

d743149

id changed from int to long

96f4c64

janheinrichmerker reviewed Mar 21, 2017

View reviewed changes

removed the inner linear layout id and the public getter in SimpleSli…

c1ca8f6

…de for it fixed the accidently wrong removed getItem and removed the duplicate goToItem instead

janheinrichmerker approved these changes Mar 21, 2017

View reviewed changes

janheinrichmerker merged commit 9b12e16 into janheinrichmerker:master Mar 21, 2017

MFlisar mentioned this pull request Sep 16, 2019

Change API design to support Drawables/Colors/... instead of just resource IDs #193

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Parent activity interface added + missing functions added #195

Parent activity interface added + missing functions added #195

MFlisar commented Mar 21, 2017

CLAassistant commented Mar 21, 2017 •

edited

Loading

janheinrichmerker Mar 21, 2017

MFlisar Mar 21, 2017

janheinrichmerker Mar 21, 2017

MFlisar Mar 21, 2017

janheinrichmerker Mar 21, 2017

janheinrichmerker Mar 21, 2017

MFlisar Mar 21, 2017

janheinrichmerker Mar 21, 2017

MFlisar Mar 21, 2017

janheinrichmerker Mar 21, 2017

janheinrichmerker Mar 21, 2017

MFlisar Mar 21, 2017

janheinrichmerker Mar 21, 2017

MFlisar Mar 21, 2017

janheinrichmerker Mar 21, 2017

MFlisar Mar 21, 2017

janheinrichmerker Mar 21, 2017

janheinrichmerker commented Mar 21, 2017

MFlisar commented Mar 21, 2017 •

edited

Loading

janheinrichmerker commented Mar 21, 2017

MFlisar commented Mar 21, 2017

janheinrichmerker commented Mar 21, 2017

janheinrichmerker commented Mar 21, 2017

MFlisar commented Mar 21, 2017

janheinrichmerker commented Mar 21, 2017

MFlisar commented Mar 21, 2017

janheinrichmerker commented Mar 21, 2017


		import android.view.View;

		/**

Parent activity interface added + missing functions added #195

Parent activity interface added + missing functions added #195

Conversation

MFlisar commented Mar 21, 2017

CLAassistant commented Mar 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janheinrichmerker commented Mar 21, 2017

MFlisar commented Mar 21, 2017 • edited Loading

janheinrichmerker commented Mar 21, 2017

MFlisar commented Mar 21, 2017

janheinrichmerker commented Mar 21, 2017

janheinrichmerker commented Mar 21, 2017

MFlisar commented Mar 21, 2017

janheinrichmerker commented Mar 21, 2017

MFlisar commented Mar 21, 2017

janheinrichmerker commented Mar 21, 2017

CLAassistant commented Mar 21, 2017 •

edited

Loading

MFlisar commented Mar 21, 2017 •

edited

Loading