Support rendering layers of measurable SVG nodes in plexus #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the prop to override how nodes are measured - Add a demo graph that uses measurable SVG nodes and overrides how they're measured - Rename the nodeRender prop to renderNode Signed-off-by: Joe Farro <joef@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #422 +/- ##
==========================================
+ Coverage 91.62% 91.67% +0.04%
==========================================
Files 176 176
Lines 4010 4010
Branches 928 928
==========================================
+ Hits 3674 3676 +2
+ Misses 298 296 -2
Partials 38 38
Continue to review full report at Codecov.
|
everett980
approved these changes
Jul 26, 2019
| ...current.measure(), | ||
| vertex: vertices[i], | ||
| vertex, | ||
| ...(measureNode && utils ? measureNode(vertex, utils) : current.measure()), |
There was a problem hiding this comment.
is the measureNode && utils to satisfy TypeScript? It seems like Boolean(measureNode) and Boolean(utils) must always be the same.
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…cing#422) Support rendering layers of measurable SVG nodes in plexus Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds the ability to render a SVG layer of measurable nodes.
Short description of the changes
Adds support for rendering measurable SVG nodes in plexus.
Additional changes:
Add the
measureNodeprop to override how nodes are measured. The use of this prop is shown in the demo.Add a demo graph that uses measurable SVG nodes and overrides how
they're measured
Rename the
nodeRenderprop torenderNode