-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove patch check from master branch #415
Remove patch check from master branch #415
Conversation
Signed-off-by: Joe Farro <joef@uber.com>
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 174 174
Lines 3915 3915
Branches 897 897
=======================================
Hits 3581 3581
Misses 296 296
Partials 38 38 Continue to review full report at Codecov.
|
@yurishkuro The intent of this PR is to remove it from the overall repo status check, which drives the green checkbox or red x next to the repo name in the header, by limiting the |
I still don't follow. Patch == PR, is it not? Or do you mean we're getting this as red on master builds? |
@yurishkuro I believe the The field coverage:
status:
patch:
default:
# basic
target: auto
threshold: null
base: auto
# advanced
branches: null
if_no_uploads: error
if_not_found: success
if_ci_failed: error
only_pulls: false
flags: null
paths: null It's my assumption that |
@yurishkuro I'm not so sure it worked. Will verify with the next PR merged. The config might replace the default for |
…master Remove patch check from master branch Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Which problem is this PR solving?
Currently if a PR that's merged to master has less than 90% coverage the Jaeger UI repo shows up as failing some checks even if the coverage for the project is above 90%.
This PR endeavor to remove the
patch
check from the master branch.Short description of the changes
Add a
.codecov.yml
config file and configure to only apply the patch check to pull requests.