Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade many dependencies part 2 #1013

Merged
merged 12 commits into from
Nov 8, 2022
Merged

Upgrade many dependencies part 2 #1013

merged 12 commits into from
Nov 8, 2022

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 5, 2022 •
edited
Loading

Which problem is this PR solving?

It upgrades several more dependencies, including webpack 5 and react 16.14
It also increases the number of PR allowed to dependabot on npm dependencies

mmorel-35 and others added 12 commits October 24, 2022 15:55
@mmorel-35
Update dependabot.yml
52167a1 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot
Bump webpack from 4.46.0 to 5.74.0
f2cbb4b 
Bumps [webpack](/~https://github.com/webpack/webpack) from 4.46.0 to 5.74.0.
- [Release notes](/~https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v4.46.0...v5.74.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mmorel-35
Merge branch 'jaegertracing:main' into main
4277057
@dependabot
Bump react-window from 1.8.7 to 1.8.8
7790d78 
Bumps [react-window](/~https://github.com/bvaughn/react-window) from 1.8.7 to 1.8.8.
- [Release notes](/~https://github.com/bvaughn/react-window/releases)
- [Changelog](/~https://github.com/bvaughn/react-window/blob/master/CHANGELOG.md)
- [Commits](/~https://github.com/bvaughn/react-window/commits)

---
updated-dependencies:
- dependency-name: react-window
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump jsdom from 20.0.1 to 20.0.2
6516af1 
Bumps [jsdom](/~https://github.com/jsdom/jsdom) from 20.0.1 to 20.0.2.
- [Release notes](/~https://github.com/jsdom/jsdom/releases)
- [Changelog](/~https://github.com/jsdom/jsdom/blob/master/Changelog.md)
- [Commits](jsdom/jsdom@20.0.1...20.0.2)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump jest from 29.2.1 to 29.2.2
5e56f6a 
Bumps [jest](/~https://github.com/facebook/jest/tree/HEAD/packages/jest) from 29.2.1 to 29.2.2.
- [Release notes](/~https://github.com/facebook/jest/releases)
- [Changelog](/~https://github.com/facebook/jest/blob/main/CHANGELOG.md)
- [Commits](/~https://github.com/facebook/jest/commits/v29.2.2/packages/jest)

---
updated-dependencies:
- dependency-name: jest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mmorel-35
Update dependabot.yml
064cb62 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@dependabot
Bump redux-promise-middleware from 4.4.2 to 5.1.1
13177c4 
Bumps [redux-promise-middleware](/~https://github.com/pburtchaell/redux-promise-middleware) from 4.4.2 to 5.1.1.
- [Release notes](/~https://github.com/pburtchaell/redux-promise-middleware/releases)
- [Commits](/~https://github.com/pburtchaell/redux-promise-middleware/commits/5.1.1)

---
updated-dependencies:
- dependency-name: redux-promise-middleware
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump cytoscape-dagre from 2.4.0 to 2.5.0
6a252e7 
Bumps [cytoscape-dagre](/~https://github.com/cytoscape/cytoscape.js-dagre) from 2.4.0 to 2.5.0.
- [Release notes](/~https://github.com/cytoscape/cytoscape.js-dagre/releases)
- [Commits](cytoscape/cytoscape.js-dagre@v2.4.0...v2.5.0)

---
updated-dependencies:
- dependency-name: cytoscape-dagre
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump babel-loader from 8.2.5 to 9.0.1
e588ddf 
Bumps [babel-loader](/~https://github.com/babel/babel-loader) from 8.2.5 to 9.0.1.
- [Release notes](/~https://github.com/babel/babel-loader/releases)
- [Changelog](/~https://github.com/babel/babel-loader/blob/main/CHANGELOG.md)
- [Commits](babel/babel-loader@v8.2.5...v9.0.1)

---
updated-dependencies:
- dependency-name: babel-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mmorel-35
Bump enzyme-adapter-react-16 from 1.10.0 to 1.15.6
91b536c 
* Bump enzyme-adapter-react-16 from 1.10.0 to 1.15.6

Bumps [enzyme-adapter-react-16](/~https://github.com/enzymejs/enzyme/tree/HEAD/packages/enzyme-adapter-react-16) from 1.10.0 to 1.15.6.
- [Release notes](/~https://github.com/enzymejs/enzyme/releases)
- [Changelog](/~https://github.com/enzymejs/enzyme/blob/master/CHANGELOG.md)
- [Commits](/~https://github.com/enzymejs/enzyme/commits/enzyme-adapter-react-16@1.15.6/packages/enzyme-adapter-react-16)

---
updated-dependencies:
- dependency-name: enzyme-adapter-react-16
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* update snapshots

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35
chore: upgrade react to 16.14.0
9023215 
* chore: upgrade react to 16.14.0

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* fix

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* up

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

* up

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review November 5, 2022 13:21
@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 95.45% // Head: 95.30% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (9023215) compared to base (369fd78).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
- Coverage   95.45%   95.30%   -0.15%     
==========================================
  Files         243      243              
  Lines        7561     7561              
  Branches     1895     1895              
==========================================
- Hits         7217     7206      -11     
- Misses        337      348      +11     
  Partials        7        7
Impacted Files Coverage Δ
...mponents/TracePage/TraceStatistics/tableValues.tsx 93.79% <0.00%> (-3.80%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

yurishkuro
yurishkuro reviewed Nov 5, 2022
View reviewed changes
...r-ui/src/components/DeepDependencies/Header/HopsSelector/__snapshots__/Selector.test.js.snap
@@ -115,7 +115,7 @@ exports[`Selector renders buttons with expected text and classNames 1`] = `
>
4
</button>
<Component
<Memo(ChevronDown)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a link to docs that explains this change?

Copy link
Contributor Author

@mmorel-35 mmorel-35 Nov 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find one, all that I found was /~https://github.com/enzymejs/enzyme/blob/master/docs/guides/migration-from-2-to-3.md and /~https://github.com/enzymejs/enzyme/blob/master/CHANGELOG.md but it seems there is not much about those Memo(), but it seems to be a React 16 feature

@yurishkuro yurishkuro merged commit bb671fb into jaegertracing:main Nov 8, 2022
@yurishkuro
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro left review comments

@everett980 everett980 Awaiting requested review from everett980

@rubenvp8510 rubenvp8510 Awaiting requested review from rubenvp8510

@tiffon tiffon Awaiting requested review from tiffon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmorel-35 @yurishkuro