fix: duplicated patterns in second phase preprocess loop

[ziqiq]

This patch removes a potential duplication in the level 2 optimization.

To reproduce, evaluate following:

new Minimatch("{a,b,*}", {optimizationLevel: 2})

Current upstream has an extra "b" in set and globParts:

Minimatch {
  options: { optimizationLevel: 2 },
  set: [ [ /^(?!\.)[^/]+?$/ ], [ 'b' ] ],
  pattern: '{a,b,*}',
  windowsPathsNoEscape: false,
  nonegate: false,
  negate: false,
  comment: false,
  empty: false,
  preserveMultipleSlashes: false,
  partial: false,
  globSet: [ 'a', 'b', '*' ],
  globParts: [ [ '*' ], [ 'b' ] ],
  nocase: false,
  isWindows: false,
  platform: 'darwin',
  windowsNoMagicRoot: false,
  regexp: null
}

This patch:

Minimatch {
  options: { optimizationLevel: 2 },
  set: [ [ /^(?!\.)[^/]+?$/ ] ],
  pattern: '{a,b,*}',
  windowsPathsNoEscape: false,
  nonegate: false,
  negate: false,
  comment: false,
  empty: false,
  preserveMultipleSlashes: false,
  partial: false,
  globSet: [ 'a', 'b', '*' ],
  globParts: [ [ '*' ] ],
  nocase: false,
  isWindows: false,
  platform: 'darwin',
  windowsNoMagicRoot: false,
  regexp: null
}

[isaacs]

That clearly is an improvement, but can you add a test that would highlight the difference? You can re-generate snapshots with npm run snap, and then include the changed snapshot in the PR, so probably all that has to be done is to add {a,*,b} to the existing test cases somewhere.

[isaacs]

Nevermind, just added the test myself :)

thanks!