Fix pagination initialization issue. #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@cxwl3sxl please help to review. |
rabbitism
changed the title
|
no feedback from reporter. merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the pagination functionality in the Ursa project, focusing on improving the handling of the current page and ensuring proper initialization. The most important changes are grouped by theme below.
Pagination Initialization and Current Page Handling:
CurrentPage="5"to thePaginationcontrol inPaginationDemo.axamlto set the default current page in the demo.CoerceCurrentPagemethod to only coerce the value if the pagination is initialized, preventing default coercion whenPageCountis not yet determined.OnPageSizeChangedto return early if the pagination is not initialized, ensuring the page count is only updated when appropriate.OnApplyTemplateto setCurrentPageusingMathHelpers.SafeClampand to callUpdateButtonsByCurrentPagewith the current page, ensuring buttons are correctly updated based on the current page.UpdateButtonsByCurrentPageto calculatecurrentPageandresidueearlier in the method for better readability and maintainability.