Marco/with after func #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## marco/drop-stream-reference #763 +/- ##
===============================================================
+ Coverage 60.48% 60.52% +0.03%
===============================================================
Files 245 245
Lines 31113 31126 +13
===============================================================
+ Hits 18819 18838 +19
+ Misses 10622 10618 -4
+ Partials 1672 1670 -2
|
MarcoPolo
force-pushed
the
marco/with-AfterFunc
branch
from
064bfa4 to
f7d0ea7
Compare
|
Note that go-libp2p doesn't yet support the conn context. I'm thinking it'll come in the next release. I just didn't want to rush it in here. |
gammazero
added a commit
that referenced
this pull request
Dec 18, 2024
refactor: if the conn has a context, use context.AfterFunc for cleanup --------- Co-authored-by: Marco Munizaga <git@marcopolo.io>
gammazero
added a commit
that referenced
this pull request
Dec 18, 2024
refactor: if the conn has a context, use context.AfterFunc for cleanup --------- Co-authored-by: Marco Munizaga <git@marcopolo.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: if the conn has a context, use
context.AfterFuncfor cleanup