get the pid namespace by following task_active_pid_ns() #3647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengyuanLiCY
requested review from
4ast,
brendangregg,
drzaeus77,
goldshtn and
yonghong-song
as code owners
When unsharing of pid namespace, though nsproxy->pid_ns_for_children is new, the process is still in the orignal pid namespace, only the forked children processes will be in the new pid namespace. So it's not correct to get process's pid namespace by nsproxy->pid_ns_for_children, should get pid namespace by task_active_pid_ns() way, i.e. pid->numbers[pid->level].ns Signed-off-by: Li Chengyuan chengyuanli@hotmail.com
|
[buildbot, test this please] |
|
@ChengyuanLiCY Thanks for the patch, I think you are correct. But let me dig into the kernel source a little bit and tried a couple of experiments to ensure it is correct. The original tool's result should mostly be correct too and most unsharing probably happened at bash level, which won't incur a lot of scheduling events. BTW, bcc python tools have the same issue. |
|
@yonghong-song Thanks for your effort to dive into the details!
I'll try to fix bcc python tool after this PR is approved. |
|
@ChengyuanLiCY I merged the patch. Please submit a pull request for python tool runqlat.py. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unsharing of pid namespace, though nsproxy->pid_ns_for_children is
new, the process is still in the orignal pid namespace, only the forked
children processes will be in the new pid namespace.
So it's not correct to get process's pid namespace by nsproxy->pid_ns_for_children,
should get pid namespace by task_active_pid_ns() way, i.e.
pid->numbers[pid->level].ns