fix: catch deploy manifest error if no capacitor CLI #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IT-MikeS
approved these changes
Jan 3, 2023
liamdebeasi
pushed a commit
that referenced
this pull request
Mar 29, 2023
liamdebeasi
pushed a commit
that referenced
this pull request
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ionic deploy manifestcommand is failing on latest release because ofcapacitor configcommand returning an error when Capacitor CLI is not installed.This change allows to fallback to reading the capacitor.config.json if no Capacitor CLI is installed as it did in previous versions.
The CLI stills errors if you try to run
ionic capacitorcommands, this just prevents the error onionic deploy manifest.Change available as @ionic/cli@6.20.7-testing.0 on testing tag