Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): add lxc checker #2538

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Conversation

ffontaine
Copy link
Contributor

Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #2538 (592c814) into main (caa5612) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2538      +/-   ##
==========================================
+ Coverage   82.95%   83.09%   +0.13%     
==========================================
  Files         594      596       +2     
  Lines        9811     9821      +10     
  Branches     1344     1344              
==========================================
+ Hits         8139     8161      +22     
+ Misses       1333     1319      -14     
- Partials      339      341       +2     
Flag Coverage Δ
longtests 82.62% <100.00%> (+0.14%) ⬆️
win-longtests 75.37% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.55% <ø> (ø)
cve_bin_tool/checkers/lxc.py 100.00% <100.00%> (ø)
test/test_data/lxc.py 100.00% <100.00%> (ø)
cve_bin_tool/cli.py 68.16% <0.00%> (+0.32%) ⬆️
cve_bin_tool/data_sources/nvd_source.py 63.07% <0.00%> (+4.56%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding "other_products": [], then running new tests. I don't anticipate further problems but I want the CI to run since the tests did actually change.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests behaving, time to merge!

@terriko terriko merged commit 1e36e3c into intel:main Jan 24, 2023
@ffontaine ffontaine deleted the add-lxc-checker branch January 25, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants