fix: improve kerberos checker #2509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffontaine
force-pushed
the
fix-kerberos-checker
branch
from
29b2882 to
08c3fe2
Compare
ffontaine
force-pushed
the
fix-kerberos-checker
branch
from
08c3fe2 to
fcdbd4a
Compare
ffontaine
added a commit
to ffontaine/cve-bin-tool
that referenced
this pull request
Jan 25, 2023
- Raise an error if one of the other_products is not found in the product list - Do not always append kerberos to all_the_tests (kerberos package_test_data will be provided by intel#2509) - Drop unneeded comment - Drop gcc, glibc, rust, sqlite, zlib, etc. from other_products if needed Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
- Drop mit:kerberos and get_version as NVD NIST has deprecated this unusual versioning since January 2020: https://nvd.nist.gov/products/cpe/detail/335C9545-32F8-4473-97BD-636F1532525F?namingFormat=2.3&orderBy=CPEURI&keyword=cpe%3A2.3%3Aa%3Amit%3Akerberos%3A5-1.5.1%3A*%3A*%3A*%3A*%3A*%3A*%3A*&status=FINAL%2CDEPRECATED - Add debian and openwrt test packages Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine
force-pushed
the
fix-kerberos-checker
branch
from
fcdbd4a to
186c3f7
Compare
Codecov Report
@@ Coverage Diff @@
## main #2509 +/- ##
==========================================
- Coverage 83.04% 83.01% -0.04%
==========================================
Files 600 600
Lines 9887 9872 -15
Branches 1355 1353 -2
==========================================
- Hits 8211 8195 -16
+ Misses 1345 1344 -1
- Partials 331 333 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ffontaine
added a commit
to ffontaine/cve-bin-tool
that referenced
this pull request
Jan 26, 2023
- Raise an error if one of the other_products is not found in the product list - Do not always append kerberos to all_the_tests (kerberos package_test_data will be provided by intel#2509) - Drop gcc, glibc, rust, sqlite, zlib, etc. from other_products if needed Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine
added a commit
to ffontaine/cve-bin-tool
that referenced
this pull request
Jan 26, 2023
- Raise an error if one of the other_products is not found in the product list - Do not always append kerberos to all_the_tests (kerberos package_test_data will be provided by intel#2509) - Drop gcc, glibc, rust, sqlite, zlib, etc. from other_products if needed Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
terriko
pushed a commit
that referenced
this pull request
Jan 26, 2023
- Raise an error if one of the other_products is not found in the product list - Do not always append kerberos to all_the_tests (kerberos package_test_data will be provided by #2509) - Drop gcc, glibc, rust, sqlite, zlib, etc. from other_products if needed Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
|
Updating branch for tests, but I think this should be ok to merge. |
terriko
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mit:kerberosandget_versionas NVD NIST has deprecated this unusual versioning since January 2020: https://nvd.nist.gov/products/cpe/detail/335C9545-32F8-4473-97BD-636F1532525F?namingFormat=2.3&orderBy=CPEURI&keyword=cpe%3A2.3%3Aa%3Amit%3Akerberos%3A5-1.5.1%3A*%3A*%3A*%3A*%3A*%3A*%3A*&status=FINAL%2CDEPRECATEDSigned-off-by: Fabrice Fontaine fabrice.fontaine@orange.com