fix: improve systemd checker #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffontaine
force-pushed
the
fix-systemd-checker
branch
3 times, most recently
from
853f703 to
73247f9
Compare
- Drop "LIBSYSTEMD_([0-4]+[0-9]+[0-9]+)(?!.*LIBSYSTEMD_([0-4]+[0-9]+[0-9]+))" pattern as it raises a false positive with dbus-daemon, libvirt and openvpn, etc which contain LIBSYSTEMD_209 - While at it, replace MULTILINE by \r?\n for consistency with other checkers - freedesktop:systemd CPE ID has been deprecated in favor of systemd_project:systemd by NVD NIST in January 2022 Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
ffontaine
force-pushed
the
fix-systemd-checker
branch
from
73247f9 to
cbd23a1
Compare
Codecov Report
@@ Coverage Diff @@
## main #2507 +/- ##
==========================================
- Coverage 82.95% 82.90% -0.06%
==========================================
Files 594 594
Lines 9811 9809 -2
Branches 1344 1344
==========================================
- Hits 8139 8132 -7
- Misses 1333 1347 +14
+ Partials 339 330 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
terriko
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Huh. I'm glad to hear that there's a better signature we can use, but I'm now mystified as to why we had to use the LIBSYSTEMD work at all if changing it doesn't break the older tests. An oversight, I guess. Thanks for digging into this one and reducing false positives!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LIBSYSTEMD_([0-4]+[0-9]+[0-9]+)(?!.*LIBSYSTEMD_([0-4]+[0-9]+[0-9]+))pattern as it raises a false positive withdbus-daemonwhich containsLIBSYSTEMD_209MULTILINEby\r?\nfor consistency with other checkersfreedesktop:systemdCPE ID has been deprecated in favor ofsystemd_project:systemdby NVD NIST in January 2022Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com