fix: Improve firefox checker pattern #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2469 +/- ##
==========================================
+ Coverage 77.79% 82.36% +4.56%
==========================================
Files 581 591 +10
Lines 9679 9729 +50
Branches 1319 1319
==========================================
+ Hits 7530 8013 +483
+ Misses 1847 1370 -477
- Partials 302 346 +44
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
BreadGenie
approved these changes
Dec 22, 2022
| "product": "firefox", | ||
| "version": "106.0.5", | ||
| "version": "83.0", |
There was a problem hiding this comment.
Seems like the pattern is available on older versions of Firefox (which is fine btw, something is better than nothing)
terriko
approved these changes
Dec 22, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2453
Changed version strings to avoid false positives