-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add triage to requirements test to address aiohttp disputed cve #1746
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
- Coverage 83.84% 83.48% -0.36%
==========================================
Files 307 307
Lines 6581 6589 +8
Branches 1068 1069 +1
==========================================
- Hits 5518 5501 -17
- Misses 820 843 +23
- Partials 243 245 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Note for Terri: change this to read a json output, check for any CVEs that are not ignored. |
The test passes for me locally with the last change. Going to let it run before explicitly tagging folk for review, but code reviews very welcome at this stage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
This PR adds triage (a merged report) into the requirements test so that we can (temporarily?) ignore the current aiohttp CVE which is unfixed and may be disputed.
add triage data for aiohttp
Update test to use triage data provided
update test so it handles ignored CVEs correctly
update merge reports documentation to give list of acceptable options in the "remarks" field.
related A dependency (aiohttp) is flagged with a moderate rated CVE #1741