Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add triage to requirements test to address aiohttp disputed cve #1746

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Jul 5, 2022

This PR adds triage (a merged report) into the requirements test so that we can (temporarily?) ignore the current aiohttp CVE which is unfixed and may be disputed.

@terriko terriko mentioned this pull request Jul 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #1746 (b8ae11e) into main (6c13a9d) will decrease coverage by 0.35%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1746      +/-   ##
==========================================
- Coverage   83.84%   83.48%   -0.36%     
==========================================
  Files         307      307              
  Lines        6581     6589       +8     
  Branches     1068     1069       +1     
==========================================
- Hits         5518     5501      -17     
- Misses        820      843      +23     
- Partials      243      245       +2     
Flag Coverage Δ
longtests 83.48% <0.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_requirements.py 0.00% <0.00%> (ø)
cve_bin_tool/available_fix/debian_cve_tracker.py 63.26% <0.00%> (-14.29%) ⬇️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/cli.py 71.09% <0.00%> (+0.39%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@terriko
Copy link
Contributor Author

terriko commented Jul 6, 2022

Note for Terri: change this to read a json output, check for any CVEs that are not ignored.

@terriko
Copy link
Contributor Author

terriko commented Jul 6, 2022

The test passes for me locally with the last change. Going to let it run before explicitly tagging folk for review, but code reviews very welcome at this stage.

@terriko terriko added the awaiting maintainer Need a maintainer to respond / help out label Jul 6, 2022
@terriko terriko requested a review from nedsouza July 6, 2022 18:50
Copy link
Contributor

@b31ngd3v b31ngd3v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@anthonyharrison anthonyharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer Need a maintainer to respond / help out
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants