test: added unit tests for format_checkers script #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashugarg
force-pushed
the
test-format-checkers
branch
from
b3e942e to
46ac054
Compare
yashugarg
force-pushed
the
test-format-checkers
branch
from
46ac054 to
e0dcd56
Compare
yashugarg
force-pushed
the
test-format-checkers
branch
from
e0dcd56 to
f7eba9c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
+ Coverage 79.43% 80.32% +0.89%
==========================================
Files 299 300 +1
Lines 6364 6404 +40
Branches 1044 1045 +1
==========================================
+ Hits 5055 5144 +89
+ Misses 1093 1043 -50
- Partials 216 217 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
@BreadGenie @terriko |
BreadGenie
reviewed
Jun 25, 2022
BreadGenie
approved these changes
Jun 25, 2022
terriko
reviewed
Jun 30, 2022
There was a problem hiding this comment.
Looks good to me. I'm re-running the windows CI stuff that timed out before I merge but I don't anticipate problems.
I did merge #1714 which switched all the other tests over to using pathlib, so we'll probably want to switch to that here too. I'll open a separate bug for a little refactoring rather than waiting on merging this, though.
|
Alright thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1708