-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rpm extractor for windows #1696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be a check that the zstd application is available before trying to run the zsd command. However could we not use the zstandard Python library instead of running the zstd command, noting that the zstandard library is already included as part of the dependencies listed in the requirements.txt file?
Codecov Report
@@ Coverage Diff @@
## main #1696 +/- ##
==========================================
- Coverage 78.76% 78.39% -0.38%
==========================================
Files 298 298
Lines 6189 6216 +27
Branches 1006 1011 +5
==========================================
- Hits 4875 4873 -2
- Misses 1096 1124 +28
- Partials 218 219 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
hi @anthonyharrison i've updated the function, can you please take a look at it now? and thank you for reviewing this pr <3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add some new tests for this building on #1682?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; thanks for making those changes!
No description provided.