Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rpm extractor for windows #1696

Merged
merged 12 commits into from
Jun 15, 2022
Merged

fix: rpm extractor for windows #1696

merged 12 commits into from
Jun 15, 2022

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v b31ngd3v commented Jun 9, 2022

No description provided.

Copy link
Contributor

@anthonyharrison anthonyharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a check that the zstd application is available before trying to run the zsd command. However could we not use the zstandard Python library instead of running the zstd command, noting that the zstandard library is already included as part of the dependencies listed in the requirements.txt file?

@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2022

Codecov Report

Merging #1696 (7379ae0) into main (09ebae5) will decrease coverage by 0.37%.
The diff coverage is 40.62%.

@@            Coverage Diff             @@
##             main    #1696      +/-   ##
==========================================
- Coverage   78.76%   78.39%   -0.38%     
==========================================
  Files         298      298              
  Lines        6189     6216      +27     
  Branches     1006     1011       +5     
==========================================
- Hits         4875     4873       -2     
- Misses       1096     1124      +28     
- Partials      218      219       +1     
Flag Coverage Δ
longtests 78.39% <40.62%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/extractor.py 54.04% <0.00%> (-4.12%) ⬇️
test/test_extractor.py 100.00% <100.00%> (ø)
cve_bin_tool/nvd_api.py 71.20% <0.00%> (-12.80%) ⬇️
cve_bin_tool/cli.py 70.90% <0.00%> (+0.40%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@b31ngd3v b31ngd3v marked this pull request as draft June 11, 2022 00:30
@b31ngd3v b31ngd3v marked this pull request as ready for review June 12, 2022 11:36
@b31ngd3v
Copy link
Contributor Author

hi @anthonyharrison i've updated the function, can you please take a look at it now? and thank you for reviewing this pr <3

Copy link
Contributor

@anthonyharrison anthonyharrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add some new tests for this building on #1682?

@b31ngd3v
Copy link
Contributor Author

b31ngd3v commented Jun 14, 2022

Do we need to add some new tests for this building on #1682?

i checked the PR (#1683), it has tests for zst and pkg but i think we need one more rpm extractor test (which uses zstd), so i added the test in this PR.

@b31ngd3v b31ngd3v requested a review from terriko June 15, 2022 08:19
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for making those changes!

@terriko terriko merged commit 0f24b06 into intel:main Jun 15, 2022
@b31ngd3v b31ngd3v deleted the 1696 branch June 15, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants