Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add options to import and export database (fixes #1655) #1656

Merged
merged 53 commits into from
Jun 16, 2022

Conversation

anthonyharrison
Copy link
Contributor

No description provided.

anthonyharrison and others added 30 commits May 27, 2020 12:55
@anthonyharrison anthonyharrison changed the title feat: Add command line options to import and export database (fixes #1655) feat: Add options to import and export database (fixes #1655) May 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2022

Codecov Report

Merging #1656 (6c66a53) into main (9a49015) will increase coverage by 1.68%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##             main    #1656      +/-   ##
==========================================
+ Coverage   78.66%   80.35%   +1.68%     
==========================================
  Files         296      298       +2     
  Lines        6141     6204      +63     
  Branches     1002     1009       +7     
==========================================
+ Hits         4831     4985     +154     
+ Misses       1093     1005      -88     
+ Partials      217      214       -3     
Flag Coverage Δ
longtests 80.35% <26.66%> (+1.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cvedb.py 84.10% <20.00%> (+11.58%) ⬆️
cve_bin_tool/cli.py 71.25% <30.00%> (-0.59%) ⬇️
cve_bin_tool/nvd_api.py 71.20% <0.00%> (-12.80%) ⬇️
cve_bin_tool/checkers/radare2.py 100.00% <0.00%> (ø)
cve_bin_tool/checkers/__init__.py 95.45% <0.00%> (ø)
cve_bin_tool/output_engine/__init__.py 58.37% <0.00%> (ø)
cve_bin_tool/checkers/rust.py 100.00% <0.00%> (ø)
test/test_data/rust.py 100.00% <0.00%> (ø)
cve_bin_tool/output_engine/console.py 96.87% <0.00%> (+0.40%) ⬆️
test/test_output_engine.py 94.91% <0.00%> (+0.72%) ⬆️
... and 9 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be the most valid use of the "request changes" button ever... but for some reason I'm seeing 0 changes in this PR. I think maybe you overwrote your branch or something?

@anthonyharrison
Copy link
Contributor Author

This might be the most valid use of the "request changes" button ever... but for some reason I'm seeing 0 changes in this PR. I think maybe you overwrote your branch or something?

Ooops. No idea how that happenned but hopefully the correct code is now available.

@anthonyharrison anthonyharrison requested a review from terriko May 5, 2022 21:35
@terriko
Copy link
Contributor

terriko commented May 24, 2022

My merge of the exploited cves code caused a conflict. I've manually resolved it through the web interface.

@terriko terriko added the awaiting maintainer Need a maintainer to respond / help out label May 24, 2022
@terriko
Copy link
Contributor

terriko commented May 24, 2022

(Flagging so I know to come back after the tests run)

@terriko
Copy link
Contributor

terriko commented Jun 8, 2022

@anthonyharrison looks like I broke the linting, if you've got a chance to update it.

@anthonyharrison
Copy link
Contributor Author

@terriko Fixed the linting problem. Ready for review.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! This should make moving the db around much safer and significantly more clear for the users who need to do that. I wonder if we could use this to do improve our github caching by having a copy in the repo?

@terriko terriko merged commit 86455c1 into intel:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting maintainer Need a maintainer to respond / help out
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants