Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add detailed flag (#781) #1588

Merged
merged 9 commits into from
Apr 26, 2022
Merged

feat: add detailed flag (#781) #1588

merged 9 commits into from
Apr 26, 2022

Conversation

XDRAGON2002
Copy link
Contributor

Closes #781

@XDRAGON2002
Copy link
Contributor Author

This got hit with the disk IO error same as in #1520. Don't know what could be the cause for this?

@terriko
Copy link
Contributor

terriko commented Mar 9, 2022

I'm going to try to run CI again to see if it happens again. I see it also got a 403 on the extended NVD tests; I wonder if we should disable that one from long tests as well until we get the NVD API key working correctly in CI?

@XDRAGON2002
Copy link
Contributor Author

XDRAGON2002 commented Mar 9, 2022

Got hit by the sqlite3 Disk I/O read only error again.
Also regarding the 403 errors, NVD API key is the proper intended solution for dealing with that, so until we have that setup the test is simply not consistent (which is the entire purpose of having a test suite). So I suppose they should be disabled for the time being.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. Can we get docs and a test so it can be merged?

@XDRAGON2002
Copy link
Contributor Author

XDRAGON2002 commented Mar 11, 2022

Added documentation and test to the PR.

Edit: Tests failed due to NVD errors, better than sqlite3 errors atleast.

@XDRAGON2002 XDRAGON2002 requested a review from terriko March 11, 2022 20:51
@terriko
Copy link
Contributor

terriko commented Mar 30, 2022

Updating branch to make sure CI is happy, but I think we're good to go here once that runs.

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #1588 (a060ef1) into main (af159c8) will increase coverage by 2.37%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##             main    #1588      +/-   ##
==========================================
+ Coverage   78.57%   80.95%   +2.37%     
==========================================
  Files         291      291              
  Lines        5975     5986      +11     
  Branches      980      982       +2     
==========================================
+ Hits         4695     4846     +151     
+ Misses       1067      932     -135     
+ Partials      213      208       -5     
Flag Coverage Δ
longtests 80.95% <89.47%> (+2.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/output_engine/__init__.py 54.14% <77.77%> (-0.31%) ⬇️
cve_bin_tool/cli.py 72.72% <100.00%> (+2.72%) ⬆️
cve_bin_tool/output_engine/util.py 97.29% <100.00%> (+0.23%) ⬆️
test/test_output_engine.py 93.87% <100.00%> (+0.17%) ⬆️
cve_bin_tool/nvd_api.py 75.00% <0.00%> (-9.49%) ⬇️
cve_bin_tool/version_scanner.py 76.95% <0.00%> (+0.78%) ⬆️
cve_bin_tool/extractor.py 59.23% <0.00%> (+1.08%) ⬆️
cve_bin_tool/checkers/glibc.py 100.00% <0.00%> (+4.16%) ⬆️
cve_bin_tool/available_fix/debian_cve_tracker.py 83.67% <0.00%> (+6.12%) ⬆️
... and 8 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@terriko
Copy link
Contributor

terriko commented Mar 30, 2022

Merging the VEX support caused some minor conflicts. I've resolved them through the web interface so CI is re-running now.

@terriko
Copy link
Contributor

terriko commented Apr 26, 2022

Had a merge conflict with the macro protection function. I believe I've resolved it from the web interface, but I'm going to wait on re-running the linters before merging. I think it is otherwise ready to go.

@terriko terriko merged commit 4f3538e into intel:main Apr 26, 2022
anthonyharrison pushed a commit to anthonyharrison/cve-bin-tool that referenced this pull request May 2, 2022
* feat: add detailed flag

* fix: add default value

* fix: default output param

* test: add detailed flag test

Co-authored-by: Terri Oda <terri@toybox.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a separate --detailed flag to generate detailed report
3 participants