-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add detailed flag (#781) #1588
Conversation
This got hit with the disk IO error same as in #1520. Don't know what could be the cause for this? |
I'm going to try to run CI again to see if it happens again. I see it also got a 403 on the extended NVD tests; I wonder if we should disable that one from long tests as well until we get the NVD API key working correctly in CI? |
Got hit by the sqlite3 Disk I/O read only error again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. Can we get docs and a test so it can be merged?
Added documentation and test to the PR. Edit: Tests failed due to NVD errors, better than sqlite3 errors atleast. |
Updating branch to make sure CI is happy, but I think we're good to go here once that runs. |
Codecov Report
@@ Coverage Diff @@
## main #1588 +/- ##
==========================================
+ Coverage 78.57% 80.95% +2.37%
==========================================
Files 291 291
Lines 5975 5986 +11
Branches 980 982 +2
==========================================
+ Hits 4695 4846 +151
+ Misses 1067 932 -135
+ Partials 213 208 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Merging the VEX support caused some minor conflicts. I've resolved them through the web interface so CI is re-running now. |
Had a merge conflict with the macro protection function. I believe I've resolved it from the web interface, but I'm going to wait on re-running the linters before merging. I think it is otherwise ready to go. |
* feat: add detailed flag * fix: add default value * fix: default output param * test: add detailed flag test Co-authored-by: Terri Oda <terri@toybox.ca>
Closes #781