Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LONG_TEST flags to backported fix tests using external data #1502

Closed
terriko opened this issue Jan 5, 2022 · 3 comments · Fixed by #1512
Closed

Add LONG_TEST flags to backported fix tests using external data #1502

terriko opened this issue Jan 5, 2022 · 3 comments · Fixed by #1512
Labels
good first issue Good for newcomers

Comments

@terriko
Copy link
Contributor

terriko commented Jan 5, 2022

We've had a couple of times where the backported fix code failed due to a network error. That's good information for us in general, but maybe not the most useful thing to have happen in CI. I think we should add LONG_TEST flags to tests that use network data other than NVD in order to improve the reliability of our short tests.

These are the ones that failed earlier, so it's probably those tests that need a LONG_TEST marker:

ERROR test/test_available_fix.py::TestAvailableFixReport::test_debian_available_fix_output
ERROR test/test_available_fix.py::TestAvailableFixReport::test_debian_backport_fix_output
ERROR test/test_available_fix.py::TestAvailableFixReport::test_redhat_available_fix_output
@XDRAGON2002
Copy link
Contributor

Opened PR #1512 that closes this issue.

@BreadGenie
Copy link
Contributor

we might not need to move these tests to LONG_TESTS now that those data are mocked in the test
refer #1513

@XDRAGON2002
Copy link
Contributor

Hm, I looked at #1513 and I suppose the mocks really do make this issue redundant.
So, I guess I'll close #1512 as soon as your PR gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants