Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard catalog_file attribute after a search #514

Merged
merged 1 commit into from
Aug 26, 2022
Merged

Discard catalog_file attribute after a search #514

merged 1 commit into from
Aug 26, 2022

Conversation

andersy005
Copy link
Member

@andersy005 andersy005 commented Aug 26, 2022 •
edited
Loading

Change Summary

This PR ensures the .esmcat.catalog_file attribute is set to None after a search.

In [1]: import intake

In [2]: cat = intake.open_esm_datastore("./tests/sample-catalogs/cesm1-lens-netcdf.json")

In [3]: cat.esmcat.catalog_file
Out[3]: '/home/andersy005/devel/intake/intake-esm/./tests/sample-catalogs/cesm1-lens-netcdf.csv'

In [4]: cat.search().esmcat.catalog_file

Related issue number

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@andersy005 andersy005 added the enhancement Issues that are found to be a reasonable candidate feature additions label Aug 26, 2022
@andersy005 andersy005 enabled auto-merge (squash) August 26, 2022 05:27
@andersy005 andersy005 merged commit 90f28bb into main Aug 26, 2022
@andersy005 andersy005 deleted the drop-catalog-file branch August 26, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Issues that are found to be a reasonable candidate feature additions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

esm_datastore keeps catalog_file in memory after a search()
1 participant
@andersy005