Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement derive macro for VersionedEvent #2

Merged
merged 12 commits into from
Nov 5, 2019
Merged

Implement derive macro for VersionedEvent #2

merged 12 commits into from
Nov 5, 2019

Conversation

ffuugoo
Copy link

@ffuugoo ffuugoo commented Nov 1, 2019

Example usage:

#[derive(Event, VersionedEvent)]
#[event(type = "user.created", version = 1)]
pub struct UserCreated;

@ffuugoo
Implement derive macro for VersionedEvent
e5e6ee0 
- change structure of cqrs_codegen::event module
- implement VersionedEvent proc-macro-derive
- deduplicate parts of Event and VersionedEvent
  proc-macro-derive implementations as
  cqrs_codegen::common module
@ffuugoo
Minor codestyle and documentation adjustments
91e3c4c
@ffuugoo
Run rustfmt on cqrs-codegen
cc36b66
@ffuugoo
Merge branch 'master' into cqrs-codegen-versioned-event
4e3d79b
@ffuugoo
Minor codestyle adjustments
0abfe20
@ffuugoo ffuugoo requested a review from tyranron November 1, 2019 11:58
tyranron
tyranron requested changes Nov 2, 2019
View reviewed changes
cqrs-codegen/src/event/common.rs Outdated Show resolved Hide resolved
@tyranron tyranron added the enhancement New feature or request label Nov 2, 2019
@tyranron tyranron mentioned this pull request Nov 2, 2019
Closed
@ffuugoo ffuugoo requested a review from tyranron November 4, 2019 08:22
tyranron
tyranron approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ffuugoo I still don't receive any FCMs from you. Next time I'll be pushed to penalize you for that.

FCM

Implement derive macro for VersionedEvent

- reorganize crate implementations to maximize code reuse

Additionally:
- remove "unsafe" feature in 'cqrs' and 'cqrs-core' crates

@tyranron tyranron changed the title WIP: Implement derive macro for VersionedEvent Implement derive macro for VersionedEvent Nov 5, 2019
@ffuugoo ffuugoo merged commit 48200a9 into master Nov 5, 2019
@ffuugoo ffuugoo deleted the cqrs-codegen-versioned-event branch November 5, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ffuugoo ffuugoo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ffuugoo @tyranron