Remove remaining print()s from the library #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmcp
approved these changes
Aug 4, 2024
danmcp
requested changes
Aug 4, 2024
There was a problem hiding this comment.
Until #80 is fixed, we probably need to make this be:
if i == max retires-1:
logger.error
break
logger.debug
Otherwise we won't give any indication of an invalid setup until the very end.
Note: This suggestion is taking the rebase into account since the break wouldn't make sense as is.
booxter
commented
Aug 5, 2024
nathan-weinberg
approved these changes
Aug 5, 2024
Use logger for any messages produced instead. Signed-off-by: Ihar Hrachyshka <ihrachys@redhat.com>
danmcp
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use logger for any messages produced instead.