Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

railtie initialization support for rails5 #122

Merged
merged 1 commit into from
Sep 9, 2016

Conversation

jonnymacs
Copy link

couldn't get a new rails 5 app to start without this change

@bleonard
Copy link
Contributor

bleonard commented Sep 8, 2016

can anyone confirm this works in other versions of rails?

@bleonard bleonard merged commit 48aa561 into instacart:master Sep 9, 2016
@jonnymacs
Copy link
Author

@bleonard thnx. Sorry wasn't able to verify backward compatabilty yet. Assume you did? If not I can do it this afternoon.

@bleonard
Copy link
Contributor

bleonard commented Sep 9, 2016

i merged it in to master and am going to do a RC on your 4.x app next week from that and other fixes.
I'm happy for you to check, though. Can't hurt to get a few eyes on it.
Thanks

@jonnymacs
Copy link
Author

ok, I tested this change with the rails 4.2.2 version of leagueheads.com and it worked. Also created an empty rails 4.0.13 project then included this version of makara and I am able to initialize and run the rails console. So I think it's safely backward compatible at least with rails4.

@bleonard
Copy link
Contributor

bleonard commented Sep 9, 2016

great, @jonnymacs. thanks so much!

@bleonard
Copy link
Contributor

included in release candidate. /~https://github.com/taskrabbit/makara/releases/tag/v0.3.7.rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants