-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve gif classification #401
Conversation
UPD1 Oh, I estimate time with prediction of 190 frames for both cases libifjs gif-frames |
test: add manual cases for DOM
feat: improve gif classification
This looks great! Can you please update the README.md to explain the new params along with this change? Then I can merge. |
get-pixels-frame-info-update "3.3.2" | ||
multi-integer-range "3.0.0" | ||
|
||
"@nsfw-filter/save-pixels@^2.3.4": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just changed a little bit this lib
@@ -553,6 +553,26 @@ | |||
"@types/yargs" "^15.0.0" | |||
chalk "^3.0.0" | |||
|
|||
"@nsfw-filter/gif-frames@1.0.2": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no changes(except types), just replace with new @nsfw-filter/save-pixels
Hi @GantMan, I finished
ps could you please take a look into |
FANTASTIC WORK!Quick note: If I merge this it will break NSFWJS.com for GIFs which is powered by CI to /~https://github.com/infinitered/nsfwjs/tree/master/example/nsfw_demo I'm OK merging and then tasking myself with updating the code in the demo, but I guess I should ask. Do you want to update the small bit of demo code? That way when I merge this, the new GIF code will go directly to NSFWJS.com? this means a small update to /~https://github.com/infinitered/nsfwjs/blob/master/example/nsfw_demo/src/App.js#L123-L127 Again, feel free to refuse. NSFWJS.com can be broken for a bit until I find time to update the site to the new syntax API. |
@YegorZaremba - can you contact me and give me your address? We'd love to mail you some swag for your contributions. My email is Gant followed by the company's domain. |
Hi @GantMan I working on /~https://github.com/nsfw-filter/nsfw-filter and have some bugs with
DOM
Current state
nsfwjs.min.js
size is 1694185 bytes => ~1.7mbNew
nsfwjs.min.js
size is 2014035 bytes => ~2mbfps
property to adjust amount of frames to predictmodel.classifyGif(GIF_IMAGE, { topk: 3, fps: 1 })