-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: export types correctly #1397
Conversation
The "exports" field of the package.json was misused for the type-declarations. Also, the type-declarations of secondary entrypoint (server.ts) of the platform packages was not generated.
I've just rebased this with the latest changes from I've confirmed it's an improvement and fixes the issue with the server type exports (evidenced by needing to remove two Thanks! |
It has been brought to my attention that the package.json I'm going to submit an alternative version of this PR that should fix the server export issues. |
It appears I was too hasty in closing this PR. The |
I've restored the |
Co-authored-by: Jess Archer <jess@jessarcher.com>
Co-authored-by: Jess Archer <jess@jessarcher.com>
The "exports" field of the package.json was misused for the type-declarations. Also, the type-declarations of secondary entrypoint (server.ts) of the platform packages was not generated.
Docs: